oneapi-src / level-zero-spec

MIT License
18 stars 27 forks source link

Defines new APIs to support Flat device model with sysman #245

Closed AshwinKumarKulkarni closed 9 months ago

AshwinKumarKulkarni commented 1 year ago

This PR addresses https://github.com/oneapi-src/level-zero-spec/issues/243

joshuaranjan commented 12 months ago

@AshwinKumarKulkarni @jandres742 @aravindksg

A confirmation regarding this PR: In flat model, If an application queries the device properties from L0 core, it might show as root device. But if we take the UUID of the same device and query the device and its properties from L0 Sysman, it "could" show as sub-device.

Isn't this a contradiction and Please share how could application decide whether the device is a sub-device or a root device?

@bellekal

jandres742 commented 11 months ago

@AshwinKumarKulkarni @jandres742 @aravindksg

A confirmation regarding this PR: In flat model, If an application queries the device properties from L0 core, it might show as root device. But if we take the UUID of the same device and query the device and its properties from L0 Sysman, it "could" show as sub-device.

Isn't this a contradiction and Please share how could application decide whether the device is a sub-device or a root device?

@bellekal

it is not a contradiction so much, it is just that Core and SYSMAN are reprenseting the system differently. Core could use any model it needs for better performance, while SYSMAN keeps a uniform view of the system.

bellekal commented 11 months ago

Another point to be considered - We may also need zeDeviceGetByUUID along with zesDeviceGetByUUID to map sysman device handle with core device handle.

aravindksg commented 10 months ago

@AshwinKumarKulkarni we are currently looking to absorb this spec effort for v1.9, could you please look into the changes and see if we need to fix/address any concerns raised above?

aravindksg commented 10 months ago

@sanilkumar0 for review as well