search

oneapi-src / level-zero

oneAPI Level Zero Specification Headers and Loader
https://spec.oneapi.com/versions/latest/elements/l0/source/index.html
MIT License
208 stars 90 forks source link

Non-ascii characters in files #103

Open SebastianLuzynski opened 1 year ago

SebastianLuzynski commented 1 year ago

There are some non-ascii characters inside files. This may cause problems with linters requiring only ascii characters, and it's against most of style guides for C++. fixed in #97

bmyates commented 1 year ago

Hi thanks for pointing this out. This file is generated from https://github.com/oneapi-src/level-zero-spec/blob/master/scripts/templates/api.h.mako

Can you check if non-ascii character is in that file?

SebastianLuzynski commented 1 year ago

image

bmyates commented 1 year ago

Thanks! Please open issue/PR in the spec repo. After changes are accepted there, the files in this repo can be regenerated.

SebastianLuzynski commented 1 year ago

@bmyates Commit to level zero spec has been merged.

bmyates commented 1 year ago

Thanks, next release here will include the changes. We are currently waiting on 1.5 spec to be finalized. It is expected soon.

eero-t commented 10 months ago

@SebastianLuzynski If this issue is now resolved, could you either close the bug, or comment what's still an issue?