oneapi-src / level-zero

oneAPI Level Zero Specification Headers and Loader
https://spec.oneapi.com/versions/latest/elements/l0/source/index.html
MIT License
208 stars 90 forks source link

clarify PCI mawBandwidth is not per lane #26

Closed bgoglin closed 2 years ago

bgoglin commented 4 years ago

Hello

Several properties structures in the sysman API have a "maxBandwidth" field near a "width" field that says how many lanes are in the link. The documentation should say whether the bandwidth is per lane or not.

Matters at least for zet_fabric_port_speed_t and zet_pci_speed_t.

From what I see PciImp::init(), it's the total bandwidth for PCI, not per lane. That's not obvious at all (but OK if documented). I didn't check for fabric port speed.

Thanks

eero-t commented 2 years ago

Links to latest docs:

First one says it's sum of all lanes. Fabric port property struct containing fabric port speed structs states also that they are sum of all lines => can be closed as fixed.

bgoglin commented 2 years ago

Yes, thanks.