oneapi-src / level-zero

oneAPI Level Zero Specification Headers and Loader
https://spec.oneapi.com/versions/latest/elements/l0/source/index.html
MIT License
208 stars 90 forks source link

Spec 1.3.0 Issues #72

Closed Kerilk closed 2 years ago

Kerilk commented 2 years ago

Hello, I had a bit of time to go over the 1.3.0 specification. I noticed a few issues. This was not thorough so there may be more.

jandres742 commented 2 years ago

hi @Kerilk thanks for checking it out!

zeDevicePciGetPropertiesExt: pProperties is inconsistently named => pPciProperties

Yes, we could change it.

zeMemFreeExt desc is inconsistently named => pFreeDesc or pMemFreeDesc or pMemoryFreeDesc

Could be. Most of our descriptors variables We have other functions with desc, like zeCommandQueueCreate and zeCommandListCreate.

ze_srgb_ext_desc_t Uses bool instead of ze_bool_t

Correct. We were already made aware of that one and a fix is coming.

AstroVPK commented 2 years ago

Fixed & will be published in an update soon...

bmyates commented 2 years ago

These issues were addressed here: https://github.com/oneapi-src/level-zero/commit/7f42f3c6e9599a9bcd995792e2bc42be27ec05ab