search

oneapi-src / oneAPI-samples

Samples for Intel® oneAPI Toolkits
https://oneapi-src.github.io/oneAPI-samples/
MIT License
915 stars 678 forks source link

FPGA: Fix namespace of deivce_ptr and host_ptr #2291

Closed steffenlarsen closed 2 months ago

steffenlarsen commented 4 months ago

Existing Sample Changes

Description

The device_ptr and host_ptr aliases in DPC++ is from the sycl_ext_intel_usm_address_spaces and as such is under the sycl::ext::intel namespace, rather than the sycl namespace. This commit fixes the namespaces of all uses of these aliases.

Replaces https://github.com/oneapi-src/oneAPI-samples/pull/2288.

External Dependencies

None.

Type of change

How Has This Been Tested?

Following the build instructions in each of the respective sample directories.

yuguen-intel commented 4 months ago

What version of the compiler are you using to test this? Internal regression tests are passing with 2024.2

steffenlarsen commented 4 months ago

This is to adjust for upcoming releases, including current https://github.com/intel/llvm. Note that sycl::device_ptr and sycl::host_ptr were deprecated in 2024.2.

yuguen-intel commented 4 months ago

Ok - thanks I'll keep your PR opened for now until the FPGA compiler integrates this upstream change - I'll merge your PR then

yuguen-intel commented 3 months ago

Some have been addressed (but not all) I'm still keeping this PR opened as I don't have a way to test it now, and we are close to the 2024.2 release. This will get merged in the 2025.0 release

yuguen-intel commented 2 months ago

All of these should have been addressed now through other PRs that we were able to validate along then way. Closing.