oneapi-src / oneAPI-samples

Samples for Intel® oneAPI Toolkits
https://oneapi-src.github.io/oneAPI-samples/
MIT License
915 stars 678 forks source link

FPGA: Remove DataBundle from convolution2d code sample, update gasket IP #2310

Closed whitepau closed 3 months ago

whitepau commented 3 months ago

Existing Sample Changes

Description

Simplify convolution2d code sample by removing the proprietary DataBundle header and replace it with std::array for simplicity and portability.

Fixes Issue#

External Dependencies

List any external dependencies created as a result of this change.

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

mdbtucker commented 3 months ago

Not sure why I was added to this review? @whitepau is there something here you'd like me to take a look at for some reason?

whitepau commented 3 months ago

Not sure why I was added to this review? @whitepau is there something here you'd like me to take a look at for some reason?

I'd like you to review the changes I made to the gasket IP in quartus_project_files.

whitepau commented 3 months ago

addressed mike's comments.