search

oneapi-src / oneCCL

oneAPI Collective Communications Library (oneCCL)
https://oneapi-src.github.io/oneCCL
Other
201 stars 72 forks source link

using namespace in header files #7

Open PovelikinRostislav opened 4 years ago

PovelikinRostislav commented 4 years ago

It's a bad practice to inject using namespace into header files like in sycl_base.hpp:

using namespace std;
using namespace cl::sycl;
using namespace cl::sycl::access;

I'll submit a PR fixing this issue and other polishing stuff (absence of used headers in a list of include files in some examples) as soon as I get some free time.

nikitaxgusev commented 1 day ago

@PovelikinRostislav the issue is fixed, I think, we can close this issue