search

oneapi-src / oneDNN

oneAPI Deep Neural Network Library (oneDNN)
https://uxlfoundation.org
Apache License 2.0
3.64k stars 1.01k forks source link

common: remove support for SyCL older than 2020 #2216

Open spalicki opened 1 week ago

spalicki commented 1 week ago

Removing SYCL 1.2.1 specific code.

vpirogov commented 1 week ago

make test

spalicki commented 1 week ago

@densamoilov @mgouicem I also wanted to remove CL/sycl.hpp header include since it is there just for compatibility with older SyCL versions. In many places we have:

#if __has_include(<sycl/sycl.hpp>)
#include <sycl/sycl.hpp>
#elif __has_include(<CL/sycl.hpp>)
#include <CL/sycl.hpp>
#else
#error "Unsupported compiler"
#endif

I wanted to simplify it to:

#if __has_include(<sycl/sycl.hpp>)
#include <sycl/sycl.hpp>
#else
#error "Unsupported compiler"
#endif
densamoilov commented 1 week ago

I also wanted to remove CL/sycl.hpp header include since it is there just for compatibility with older SyCL versions.

@spalicki, I think it should be fine.

spalicki commented 6 days ago

make test

spalicki commented 4 days ago

make test

spalicki commented 8 hours ago

make test