oneapi-src / oneDNN

oneAPI Deep Neural Network Library (oneDNN)
https://uxlfoundation.org
Apache License 2.0
3.64k stars 1.01k forks source link

Improvements for commit message checker #2220

Closed vpirogov closed 5 days ago

vpirogov commented 6 days ago

Three main things:

Sample output:

47f9fbd58700f56cf3732b946b40a1e6cbc5a7db governance: extended commit message length limit to 100
Message length: OK
Message scope:  OK
6de15ad81ed6bb86c1d92c689ac0a796afbbb449 TMP: commit with veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery long message
Message length: FAILED: Commit message summary must not exceed 100 characters.
Message scope:  OK
2370ea1c1ae4e2b112be8bdfa73fa3bc62dcd400 TMP cpu: commit with bad scope
Message length: OK
Message scope:  FAILED: Same-level scopes must be comma-separated. Bad token: 'TMP cpu'
cc51ad99ea0b9ea3d0166f0fab5dec57144ce5b3 TMP 360 noscope commit for testing purposes
Message length: OK
Message scope:  FAILED: Commit message does not include scope
6633c64686882a55b8988bc9c4ce8667114f00c4 github: worklflows: fixed checkout depth
Message length: OK
Message scope:  OK
777109c9d17d6a59b3eae0c4b7c0683a693f7743 github: automation: fixed git command in message checker
Message length: OK
Message scope:  OK
03f2b9f404b949a9de6978974614ecd486274d22 github: automation: improved diagnostics for commit message checker
Message length: OK
Message scope:  OK
Some commit message checks failed. Please align commit messages with Contributing Guidelines and update the PR.

Demo/Test: https://github.com/vpirogov/oneDNN/pull/1

theComputeKid commented 5 days ago

Thank you for this, and the pain you had to go through to check that it worked!