search

oneapi-src / oneDPL

oneAPI DPC++ Library (oneDPL) https://software.intel.com/content/www/us/en/develop/tools/oneapi/components/dpc-library.html
Apache License 2.0
716 stars 113 forks source link

update of dr::shp::sort() #1614

Closed lslusarczyk closed 1 month ago

lslusarczyk commented 2 months ago

propagation of change https://github.com/oneapi-src/distributed-ranges/pull/740 and https://github.com/oneapi-src/distributed-ranges/pull/759

lslusarczyk commented 2 months ago

@mateuszpn ,

  1. format test is failing, both in this PR and in your https://github.com/oneapi-src/oneDPL/pull/1608 - please make it passing. But do it automatically, not manually. Look at oneDPL CI what command do they invoke to check format and invoke the same or similar one to fix the format of your change.
  2. you have added dr namespace where it is not needed, e.g. changed distributed_range into dr::distributed_range. Please revert. Don't use namespace if you are already in this namespace. (dr::ranges::rang -> ranges::rank, dr::shp::__detail::local -> __detail::local). Shorter code increases readability.
  3. Don't use internal bug tracker IDs like [GSD-3893] in oneDPL
  4. ONEDPL_USE_DISTRIBUTED_RANGES is not used in the code - remove from cmake.
  5. Is -ftemplate-backtrace-limit=0 really needed by this change. I don't think so because it was not needed before your change and the change does not add more templates.