Open AnuyaWelling2801 opened 1 month ago
Looks like we have a lot of duplicated code in the files
And one significant diff between them that I found is:
my_policy_t p{u};
<-> my_policy_t p(u, offset);
auto test_resource = f(i);
<-> auto test_resource = f(i, offset);
But I believe we have a lot of patterns to avoid this code duplications and to have only one copy of this code.
@AnuyaWelling2801 Looks like we have some type which declared but never tested:
template <typename Policy>
using wait_t = typename policy_traits<Policy>::wait_type;
I mean wait_t
type.
Could you please use this type in tests too?
May be instead of return typename oneapi::dpl::experimental::policy_traits<Policy>::wait_type{};
or somewhere else...
Realized that the fixed resource tests for both sycl and inline backends did not account for offsets. Fixed it by creating two new files in test/support for tests with and without offsets