Avoid extra sycl::buffer tests

oneapi-src / oneDPL

oneAPI DPC++ Library (oneDPL) https://software.intel.com/content/www/us/en/develop/tools/oneapi/components/dpc-library.html

Apache License 2.0

721 stars 113 forks source link

Avoid extra sycl::buffer tests #1656

Closed SergeyKopienko closed 3 months ago

SergeyKopienko commented 3 months ago

Previously sycl::buffer tests rans from test1buffer, test2buffers, test3buffers and from test4buffers functions for each type of alloc_type template param: for sycl::usm::alloc::shared and for sycl::usm::alloc::device.

It's look like as extra overhead which we should avoid to reduce CI test time.

Now sycl::buffer tests runs only for alloc_type template param equal to sycl::usm::alloc::shared (by default).

SergeyKopienko commented 3 months ago

Agree with reverting. I missed that test3buffers is used at both levels. LGTM with green CI.

Not only test3buffers :

for example, also we have the call of test1buffer like

test1buffer<sycl::usm::alloc::device, ValueType, test_is_heap<ValueType, PermItIndexTag>>();

danhoeflinger commented 3 months ago

Agree with reverting. I missed that test3buffers is used at both levels. LGTM with green CI.

Not only test3buffers :

for example, also we have the call of test1buffer like
test1buffer<sycl::usm::alloc::device, ValueType, test_is_heap<ValueType, PermItIndexTag>>();

Ah, OK. Its confusing to position the overloads like this with both different template parameters and defaulted normal parameters. I'd prefer these overloads to be named differently for clarity (but that's just my opinion, of course). In any case, its clear that the default is needed in both places.