search

oneapi-src / oneDPL

oneAPI DPC++ Library (oneDPL) https://software.intel.com/content/www/us/en/develop/tools/oneapi/components/dpc-library.html
Apache License 2.0
720 stars 114 forks source link

Remove incorrect noexcept specifications from algorithms that may throw #1720

Closed timmiesmith closed 1 month ago

timmiesmith commented 1 month ago

Additional static analysis of oneDPL tests has identified other algorithms specified as 'noexcept' that may throw. This PR extends similar work done in #1640.

SergeyKopienko commented 1 month ago

I think this problem i smore complicated. Looks like this PR fixed only one problem case in code and probably we still have a lot of another cases.

timmiesmith commented 1 month ago

I think this problem i smore complicated. Looks like this PR fixed only one problem case in code and probably we still have a lot of another cases.

I'm addressing the issues as they're identified by the static analysis. I'd prefer to continue this approach instead of taking a broader approach that may remove the qualifier where we may actually be able to use it.