search

oneapi-src / oneDPL

oneAPI DPC++ Library (oneDPL) https://software.intel.com/content/www/us/en/develop/tools/oneapi/components/dpc-library.html
Apache License 2.0
720 stars 114 forks source link

Move merge/merge-sort device patterns into separate files #1732

Closed dmitriy-sobolev closed 1 month ago

dmitriy-sobolev commented 1 month ago

This PR moves merge and merge-sort patterns into separate files similarly to parallel_backend_sycl_reduce.h. Additionally. it replaces ::std with std according to the earlier agreed coding guideline.

This is a preparation step for adding a single-work-group implementation for merge-sort, which may inflate already large parallel_backend_sycl.h file.

mmichel11 commented 1 month ago

From a visual review, the changes LGTM. Did you try manually running a merge / sort DPCPP backend test as a sanity check since the GH CI only runs the sycl iterator tests?

dmitriy-sobolev commented 1 month ago

From a visual review, the changes LGTM. Did you try manually running a merge / sort DPCPP backend test as a sanity check since the GH CI only runs the sycl iterator tests?

Yes. I've done it: the tests pass.

dmitriy-sobolev commented 1 month ago

I've also applied clang-format. @mmichel11 and @julianmi, could you reapprove the PR?