oneapi-src / oneMKL

oneAPI Math Kernel Library (oneMKL) Interfaces

Apache License 2.0

624 stars 159 forks source link

[RNG] Workaround for get_multi_ptr with AdaptiveCPP #535

Closed iMartyan closed 4 months ago

iMartyan commented 4 months ago

Description

This fix adds a workaround for AdaptiveCPP compiler as they not yet support the get_multi_ptr function.

Checklist

All Submissions

[x] Do all unit tests pass locally? Attach a log.
[x] Have you formatted the code using clang-format?

iMartyan commented 4 months ago

acpp_log.txt

Test log

Rbiessy commented 4 months ago

Did you notice that AdaptiveCpp merged this PR recently? https://github.com/AdaptiveCpp/AdaptiveCpp/pull/1452 I think this should add support for get_multi_ptr so this fix may not be needed anymore.

iMartyan commented 4 months ago

Did you notice that AdaptiveCpp merged this PR recently? AdaptiveCpp/AdaptiveCpp#1452 I think this should add support for get_multi_ptr so this fix may not be needed anymore.

Thank you for pointing that! I see that they have not updated the version yet: Releases. I suggest to leave the workaround for now and drop it when SYCL2020 will be officially supported in AdaptiveCPP.

Rbiessy commented 4 months ago

"Officially supporting SYCL 2020" may be more complicated than it sounds but it's fair to keep this workaround until a release of AdaptiveCpp is able to compile oneMKL Interface. Thanks