oneapi-src / oneTBB

oneAPI Threading Building Blocks (oneTBB)
https://oneapi-src.github.io/oneTBB/
Apache License 2.0
5.68k stars 1.02k forks source link

TBB_BUILD_APPLE_FRAMEWORKS missing headers #1512

Open wtholliday opened 1 month ago

wtholliday commented 1 month ago

The frameworks generated by TBB_BUILD_APPLE_FRAMEWORKS have no headers. Is there a way to enable copying them? Does something need to be updated in CMakeLists.txt?

image

thanks!

wtholliday commented 1 month ago

There's this:

if(TBB_BUILD_APPLE_FRAMEWORKS)
    set_target_properties(tbb PROPERTIES
        FRAMEWORK TRUE
        FRAMEWORK_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_BUNDLE_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        MACOSX_FRAMEWORK_SHORT_VERSION_STRING ${TBB_BINARY_VERSION})
endif()

Probably should also have a value for PUBLIC_HEADER

wtholliday commented 1 month ago

See docs for FRAMEWORK https://cmake.org/cmake/help/latest/prop_tgt/FRAMEWORK.html

wtholliday commented 1 month ago

I tried adding PUBLIC_HEADER "../include/oneapi/tbb.h" but CMake doesn't stick the file in the framework, and also doesn't even print a warning.

wtholliday commented 1 month ago

Someone suggested that the headers should be added using add_library as well, as in the FRAMEWORK docs example. Doesn't seem like they are.