search

onebarloop / capstone-project

You can check out the App over at Vercel ⬇️⬇️⬇️
https://wannado-sand.vercel.app/
3 stars 0 forks source link

Like button #10

Closed onebarloop closed 1 year ago

onebarloop commented 1 year ago

I wrote a function to add bookmarked artist-id's to a state array. This array renders the favorites artists list.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wannado ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 4:11PM (UTC)
onebarloop commented 1 year ago

There's a lot of typescript in there that I don't fully understand, but it obviously works (I looked at the preview and the code) so I have nothing to complain about. I just added a comment below. on another note, since I looked at your preview already, I have a comment about QA: the cursor doesn't change upon hovering over the Standard View, Artist View, and Favourite buttons. It took me a while to realize that I could click those elements. This is something to keep in mind, but it's not super urgent since the target format is mobile anyway.

Good catch, I will change this before QA. Thanks for the review :)

onebarloop commented 1 year ago

looks very good for me ! I think you will delete the notes later

Thanks! Yes, I forgot that one! 😁