onebeyond / generator-systemic

A yeoman-based template to generate a systemic microservice
MIT License
24 stars 10 forks source link

V2.3.x into master #65

Closed MatteoDiPaolo closed 4 years ago

MatteoDiPaolo commented 4 years ago

Description

This PR will add to the generator-systemic the possibility to generate not only the basic and without-business-logic version of a systemic-based microservice but as well the show-case version of it.

Once again with this approach we

Usage:

How to review this PR

The newly added --extra-components flag is retrieved in generators/app/index.js and then set as a prop for the generator. That prop is the one used in order to:

A more detailed description of this new capabilities can be found in:

I would recommend to the reviewers to run yo systemic --extra-components and check the generated microservice starting from a carefully reading fo the generated README.

Issues solved by this PR

UlisesGascon commented 4 years ago

cc: @jgleal

MatteoDiPaolo commented 4 years ago

@kevinccbsg

It looks good to me. I would change this --extra-components to --showcase.

It makes sense I can go for it. --> done here

In the showcase @MatteoDiPaolo I would change the sleep command we use for the tests. I would add the infra and test scripts in the README so the developer will be aware that he needs the infra running to run the showcase tests. If I was using it I wouldn't like to wait for the sleep command on every test.

It makes sense I can go for it. --> done here

MatteoDiPaolo commented 4 years ago

@Betisman I see you reacting with emojis to messages in this PR, feel free to give us your point of view as well on this.

Betisman commented 4 years ago

@MatteoDiPaolo I would need a code review. 25 files about something I wasn't involved at all... please, help!

feliun commented 4 years ago

@MatteoDiPaolo I'm happy with this approach, I reviewed all files