Closed MatteoDiPaolo closed 4 years ago
cc: @jgleal
@kevinccbsg
It looks good to me. I would change this
--extra-components
to--showcase
.
It makes sense I can go for it. --> done here
In the showcase @MatteoDiPaolo I would change the sleep command we use for the tests. I would add the infra and test scripts in the README so the developer will be aware that he needs the infra running to run the showcase tests. If I was using it I wouldn't like to wait for the sleep command on every test.
It makes sense I can go for it. --> done here
@Betisman I see you reacting with emojis to messages in this PR, feel free to give us your point of view as well on this.
@MatteoDiPaolo I would need a code review. 25 files about something I wasn't involved at all... please, help!
@MatteoDiPaolo I'm happy with this approach, I reviewed all files
Description
This PR will add to the generator-systemic the possibility to generate not only the basic and without-business-logic version of a systemic-based microservice but as well the show-case version of it.
Once again with this approach we
yo systemic
yo systemic:advanced
Would you like to have a showcase including extra components?
Usage:
yo systemic
yo systemic --extra-components
How to review this PR
The newly added
--extra-components
flag is retrieved ingenerators/app/index.js
and then set as a prop for the generator. That prop is the one used in order to:props.filesToSkip
ingenerators/app/index.js
<%_ if (extraComponents) { -%> "error-handler-module": "^1.0.3", <%_ } -%>
ingenerators/app/root/_package.json
A more detailed description of this new capabilities can be found in:
README.md
generators/app/templates/root/_README.md
I would recommend to the reviewers to run
yo systemic --extra-components
and check the generated microservice starting from a carefully reading fo the generated README.Issues solved by this PR
17 --> the error-handler-module package has been added in the show-case version in order to show http errors handling capabilities. This would made the PR #41 obsolete.
54
25
59
14
11
6