search

onebone / EconomyS

The economy plugin for PocketMine-MP
GNU General Public License v3.0
144 stars 191 forks source link

Error EconomyProperty #458

Open AirLeMineral opened 3 years ago

AirLeMineral commented 3 years ago

[Server thread/CRITICAL]: Error: "Call to undefined method onebone\economyland\EconomyLand::getInstance()" (EXCEPTION) in "plugins/EconomyProperty/src/onebone/economyproperty/EconomyProperty" at line 239

if you have determined the first position and second position, then use the command /property make (price) (ren time) error

onebone commented 3 years ago

EconomyProperty requires EconomyLand to be installed. Could you check if it does?

AirLeMineral commented 3 years ago

EconomyProperty requires EconomyLand to be installed. Could you check if it does?

i am trying to use the old version of economyland and it works, because the newest version is not working. i dont know why but I found a new error Error: "Call to a member function canBeReplaced() on int" (EXCEPTION) in "plugins/EconomyProperty/src/onebone/economyproperty/EconomyProperty" at line 260

onebone commented 3 years ago

I think my plugin is not working as it is outdated for now. I think I could not make time for fixing this for a while so I ask you to search for an alternative. I will leave this issue until I update the plugin.

GalonAquaa commented 3 years ago

I think my plugin is not working as it is outdated for now. I think I could not make time for fixing this for a while so I ask you to search for an alternative. I will leave this issue until I update the plugin.

where can I find an alternative? I haven't found it yet :(

fuyutsuki commented 3 years ago

I'm currently working on a PR for this issue, but which plugin should implement these constants? https://github.com/onebone/EconomyS/blob/b61fab92594e7d08c012073c2805d9daeec6c308/EconomyProperty/src/onebone/economyproperty/EconomyProperty.php#L150-L160

onebone commented 3 years ago

I'm currently working on a PR for this issue, but which plugin should implement these constants? https://github.com/onebone/EconomyS/blob/b61fab92594e7d08c012073c2805d9daeec6c308/EconomyProperty/src/onebone/economyproperty/EconomyProperty.php#L150-L160

Those constants are the legacy stuffs that had to be existed in the former version of EconomyLand. Please browse here for the actual code. Shamefully, the plugins in this repository are in inconsistent state where some dependencies does not match its required version. The EconomyLand at 3.x branch is almost at a complete stage except for some missing features such as expiration, and the money transaction feature which is blocked by the work on the api/transaction branch. Although the API of EconomyLand may change as it is still in a development stage, I appreciate a PR using the new Land API.

fuyutsuki commented 3 years ago

I understand that EconomyLand 3.x is almost complete, but it looks like EconomyLand doesn't have an API that returns the equivalent of those old constants. Therefore, I am not sure whether I should put those constants in EconomyLand temporarily or in EconomyProperty, which has not been updated yet.

onebone commented 3 years ago

I understand that EconomyLand 3.x is almost complete, but it looks like EconomyLand doesn't have an API that returns the equivalent of those old constants. Therefore, I am not sure whether I should put those constants in EconomyLand temporarily or in EconomyProperty, which has not been updated yet.

As a workaround, I think it is best to check if there is an overlapping land region using LandManager::getLandAt() for all 4 anchors of a land. Though it sacrifices performance and yields some database synchronization problems, creating land is not an operation that is frequently requested so I think it is a valid option as a temporary fix.

fuyutsuki commented 3 years ago

NOTE: there are a couple more errors that need to be fixed to get EconomyProperty working.

chisi21 commented 3 years ago

NOTE: there are a couple more errors that need to be fixed to get EconomyProperty working.

Error: "Call to a member function canBeReplaced() on int" (EXCEPTION) in "plugins/EconomyProperty/src/onebone/economyproperty/EconomyProperty" at line 266

PMMP VER : 3.21.0 PHP: 7.4

onebone commented 3 years ago

Oops I confused this issue with the PR. Reopening it.

fuyutsuki commented 3 years ago

Additional PRs will be submitted.

AirLeMineral commented 3 years ago

PR tambahan akan dikirimkan.

I will wait for it :D

KygekDev commented 3 years ago

PR tambahan akan dikirimkan.

I will wait for it :D

LOL, looks like he used Google Translate to translate this page to Indonesian.

AirLeMineral commented 3 years ago

PR tambahan akan dikirimkan.

I will wait for it :D

LOL, looks like he used Google Translate to translate this page to Indonesian.

Sry, automatic 😁