search

onecentlin / laravel5-snippets-vscode

Laravel snippets for Visual Studio Code (Support Laravel 5 and above)
MIT License
36 stars 19 forks source link

double instead of single-quotes in log snippets #28

Closed MartinP7r closed 3 years ago

MartinP7r commented 4 years ago

Since I most often have to delete the single quotes in the log snippets in order to use string interpolation like 

\Log::debug("some $variable here");

I'd propose to either replace all single quoted log methods in https://github.com/onecentlin/laravel5-snippets-vscode/blob/master/snippets/log.json with double-quotes or make the quotes part of the initial tabbable shortcuts like

"Log::debug(${1:'${2:message}'});$3"

I could submit a PR if you'd like. If there's no preference I'd go with the first solution.

MartinP7r commented 3 years ago

Any thoughts on this?

onecentlin commented 3 years ago

@MartinP7r Sure, please summit a PR. Thanks.

MartinP7r commented 3 years ago

Merged in #32