search

oneclick / rubyinstaller2

MSYS2 based RubyInstaller for Windows
https://rubyinstaller.org
BSD 3-Clause "New" or "Revised" License
644 stars 248 forks source link

MSYS2 OpenSSL changed from 'etc/ssl' to 'bin/etc/ssl' #337

Closed MSP-Greg closed 1 year ago

MSP-Greg commented 1 year ago

Lars,

Another fun MSYS2 change. See https://github.com/msys2/MINGW-packages/pull/16141.

Or, the following have all changed:

OpenSSL::X509::DEFAULT_CERT_FILE
OpenSSL::X509::DEFAULT_CERT_DIR
OpenSSL::Config::DEFAULT_CONFIG_FILE
lazka commented 1 year ago

https://github.com/msys2/MINGW-packages/pull/16141 wasn't supposed to change anything for the common case. Do you have any idea why this affects you?

MSP-Greg commented 1 year ago

for the common case

The MSYS2 dll's included with Ruby are located in bin/ruby_builtin_dlls, so they are not accessible via PATH. This was done to alleviate problems with all the various Windows 'apps' that may share dll names.

Ruby's bin & exe files are in the bin folder. So, a long time ago, 'certs' were in the ssl folder, then moved to etc/ssl. With the recent change of the path being relative to the OpenSSL dll's path, it's now at bin/etc/ssl.

lazka commented 1 year ago

uh, I see. I don't have a good idea on how to make both cases work :(

MSP-Greg commented 1 year ago

Other than removing a trialing bin (or something similar) from the folder, I also don't see a good way of fixing it.

larskanis commented 1 year ago

Thank you @MSP-Greg and @lazka for investigating this issue. I dithered between using a forked build script and accepting the new path, but decided to do the latter. It is a user visible change, since some users place their own certificates at the openssl path. They have to move it now. I hope it will be the last path change for the foresight future!

MSP-Greg commented 1 year ago

I hope it will be the last path change for the foresight future

Strongly agree...