onecodex / finch-rs

A genomic minhashing implementation in Rust
https://www.onecodex.com
MIT License
93 stars 8 forks source link

split finch-rs into library and binary #48

Closed maxbla closed 3 years ago

maxbla commented 4 years ago

Libraries should not have a cargo.lock whereas binaries should. The fact that finch-rs doesn't have a lockfile means that the finch-rs binary can't easily continue supporting a particular version of Rust without constantly running CI to verify that it compiles. A (possibly transitive) dependency could be updated at any time, breaking the build (this happened when I was working on #46). A lockfile prevents the build breaking at any time, but is ignored by libraries. The library version of finch-rs would need a minimum rust version of stable, since some of its dependencies require stable (for example object).