search

onecodex / finch-rs

A genomic minhashing implementation in Rust
https://www.onecodex.com
MIT License
92 stars 8 forks source link

retcode is 0 when finch exits in error #5

Closed audy closed 7 years ago

audy commented 7 years ago

Finch exits with a 0 if it encounters an error. Happens with dist and sketch. I haven't tried producing any other errors except for the file not found one.

$ finch dist idontexist && echo $? Error: No such file or directory (os error) 0

bovee commented 7 years ago

Thanks for noticing and submitting! This should be fixed on master now and on cargo install whenever I cut 0.1.4 and publish it (in the next week or so).

audy commented 7 years ago

Thanks!

On Fri, Sep 22, 2017 at 4:29 PM, Roderick Bovee notifications@github.com wrote:

Thanks for noticing and submitting! This should be fixed on master now and on cargo install whenever I cut 0.1.4 and publish it (in the next week or so).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/onecodex/finch-rs/issues/5#issuecomment-331479943, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHEwEBx7Zp5C3SeIsUpAYXbxbgY2WRIks5sk9JDgaJpZM4PgdcC .

-- --austin