search

onecommons / unfurl-gui

vue + apollo + gitlab-ui
Other
5 stars 0 forks source link

Fix formily file selector regression, start on file selector unit tests #442

Closed AjBreidenbach closed 11 months ago

aszs commented 11 months ago

looks like there are a lot of new dependencies added around babel? is there much risk with those changes?

aszs commented 11 months ago

is the pipeline failure related to those changes? e.g.:

FAIL packages/oc-pages/vue_shared/lib/directives/index.test.js ● Test suite failed to run

Cannot find module '@babel/preset-env'
AjBreidenbach commented 11 months ago

Sorry missed this -

Cannot find module '@babel/preset-env'

That's really mind boggling. The issue before was that the build and jest wanted different babel configs. Now somehow yarn.lock isn't protecting us from "it works on my machine". I guess I'll try clearing cache in case I can reproduce.

looks like there are a lot of new dependencies added around babel? is there much risk with those changes?

None of these package changes apply to the oc-pages package (and gitlab-oc by extension). The unfurl-gui package already couldn't build because the same setup wasn't working between jest and webpack.

AjBreidenbach commented 11 months ago

28 passing now after explicitly adding the dependency to package.json... not sure why this didn't matter before.

aszs commented 11 months ago

only 2 failing now... should we disable those ones for automated test runs? or are they easy to fix?