Complete tests for decks endpoints - Githubissues

onecrayon / api.ashes.live

Backend API for a fan-developed deckbuilder and community website for the card game Ashes Reborn

ISC License

13 stars 3 forks source link

Complete tests for decks endpoints #29

Closed onecrayon closed 3 years ago

onecrayon commented 3 years ago

I'm not going to have time to complete the test suite prior to soft-launching deck editing, so this is a follow-up task. 😞

General

[x] Write utility method to allow easy population of decks with randomized contents based on available cards
[ ] Refactor the card tests to use a similar pattern of creating objects in a nested transaction, and then overriding the default client and session fixtures

Need coverage

[x] PUT /v2/decks
[x] POST /v2/decks/{id}/snapshot
[x] PATCH /v2/decks/snapshots/{snapshot_id}
[x] GET /v2/decks
[x] GET /v2/decks/mine
[x] GET /v2/decks/{id}
[x] GET /v2/decks/{id}/snapshots
[ ] DELETE /v2/decks/{id}

Problems

[x] Possible to save a conjuration in a deck
[x] First five, effect costs, and tutor map are not being returned after PUT-ing a deck