onedr0p / containers

My collection of container images
https://github.com/onedr0p?tab=packages&repo_name=containers
Apache License 2.0
300 stars 79 forks source link

BREAKING: Switch to official env var support for radarr, sonarr, prowlarr readarr and lidarr #1013

Closed onedr0p closed 3 months ago

onedr0p commented 5 months ago

[!IMPORTANT] The containers below will be modified after their stable release is cut with the env changes, and it will be a breaking change. The entrypoint.sh script will be simplified and xmlstarlet, envsubst will be removed. I will do my best to update this issue when this happens. I urge people to subscribe to this issue for updates.

These apps will start to begin to support env var for config.xml items.

I also recommend people to switch to the new environment variables as soon as it's supported upstream on your given branch. This will ensure you don't have any issues once the old envsubt method is gone.

You can see an example I did here with Sonarr/develop.

I apologize in advance for any one who does not notice or pay attention to this issue when the breaking changes occur.

onedr0p commented 4 months ago

Develop release for Prowlarr, Radarr, and Sonarr are all updated with new env and ability to disable the log database.

https://github.com/onedr0p/home-ops/commit/8fa283022929bfbe818b69d875f482feed41d9ed https://github.com/onedr0p/home-ops/commit/67607bfedf21896112644338719e3fd92aad5900

onedr0p commented 4 months ago

Env appears to be supported in Lidarr https://github.com/Lidarr/Lidarr/commit/30d9891bf0ee4dd126cb5a4211cd85c68c9156c0

Readarr still pending as of now https://github.com/Readarr/Readarr/pull/3482

sillock1 commented 4 months ago

Env appears to be supported in Lidarr Lidarr/Lidarr@30d9891

Readarr still pending as of now Readarr/Readarr#3482

This should be in Readarr on the next develop release

onedr0p commented 4 months ago

Lidarr changes are done. New builds will only accept officially supported ENV. https://github.com/Lidarr/Lidarr/pull/4812

onedr0p commented 4 months ago

Radarr changes are done. New builds will only accept officially supported ENV. https://github.com/Radarr/Radarr/pull/9985

onedr0p commented 4 months ago

Sonarr changes are done. New builds will only accept officially supported ENV. https://github.com/Sonarr/Sonarr/pull/6746

onedr0p commented 4 months ago

Prowlarr changes are done. New builds will only accept officially supported ENV. https://github.com/Prowlarr/Prowlarr/commit/04bb0c51b1b45fcc7f99d07ad4723ef7a55ca89b

onedr0p commented 3 months ago

Readarr changes are done. New builds will only accept officially supported ENV. https://github.com/Readarr/Readarr/pull/3482