Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

onedr0p / exportarr

AIO Prometheus Exporter for Sabnzbd, Bazarr, Prowlarr, Lidarr, Readarr, Radarr, and Sonarr

MIT License

575 stars 43 forks source link

Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing #299

Open codefaux opened 6 months ago

codefaux commented 6 months ago

Description of the change

Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

Benefits

Faster metrics collection for users not desiring History/Wanted/Missing
Stall mitigation re: users with large collections or long-lived instances

Possible drawbacks

I don't know Golang or koanf and did not look up reference for either, but I believe I have treated both appropriately.

Applicable issues

Additional information

Thanks for your work.

onedr0p commented 6 months ago

Changes appear good here, but I wonder if it could be added to the logic --enable-additional-metrics flag instead of creating separate config flags / env options? I am not sure if there is a use-case for why you would want --enable-additional-metrics on but turn off the history & wanted/missing flags? The --enable-additional-metrics flag was mainly created for those with large libraries that need to turn off the slower API calls.

Also @rtrox would be great if/when you are free to review to get a pair of second eyes on this.

rtrox commented 3 months ago

Thanks for the PR @codefaux! Sorry about the delayed review here, been dealing with some issues in RL. A few comments, but overall looks good!

onedr0p / exportarr

Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing #299

298