oneezy / monorepo

Turborepo + Sveltekit + PNPM + Tailwind + Histoire
https://oneezy-monorepo.vercel.app
MIT License
87 stars 9 forks source link

Remove docs layout casuing duplicate socials #6

Closed JarrodKane closed 1 year ago

JarrodKane commented 1 year ago

I think there was an extra layout file added into the docs route when the parent routes layout is doing what it needs to do already. This file looked to not be doing much but it was adding an extra row of socials for no reason above the already existing one.

I've just removed the file for now to remove the extra layer of socials.

I thought I would just create this PR while checking out this cool project because the fix is so quick. Is there a contribution guide for this project?

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
monorepo ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 11:14AM (UTC)
oneezy commented 1 year ago

hey @JarrodKane ! thanks for your contribution and interest in the project!

I actually fixed this on my end along with a ton of other things so I'm going to hold off on merging this PR.

Still trying to fix a few items on this end before I release but here's a little preview of what's coming (hopefully later today)

To do


For Contributing,

If you have a feature or bug fix , best thing to do is create an issue so we can start a discussion around it and figure out the best plan

oneezy commented 1 year ago

just did a push @JarrodKane , let me know if that fixed things

JarrodKane commented 1 year ago

@oneezy That's great work, I'll keep following as I'm working with a similar tech stack for work, and my own private repos. I'll create an issue from now on first, thanks for the feedback

oneezy commented 1 year ago

Thanks @JarrodKane ! Sounds like a plan. Gad it worked for you