onefangg / pe

0 stars 0 forks source link

find command does not indicate that the character limit of all keywords combined cannot exceed 30 #9

Open onefangg opened 2 years ago

onefangg commented 2 years ago

image.png

From the command message, all the keywords (delimited by spaces) inputted "job", "and" etc. don't exceed 30 letters, which would indicate that all role keywords passed in is correct and valid.

image.png

Only after removing "engineering", was the command successful. The previous error message did not include a limit on the number of keywords I can pass in, only indicating that it's a character limit

nus-pe-bot commented 2 years ago

Team's Response

This is a flaw that is unlikely to affect operation of app as the find feature is used to filter companies and roles to display a smaller subset of the companies and roles in a list.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Their UG and application does not indicate that there is a number of restriction on the number of keywords, but only the restriction on the number of characters in a single keyword (max 30 characters).

Hence if the user wants to do command find r/Berkshire Accenture Astrazeneca - to just search for 3 companies - the command will not be successful, and throw an error instead to indicate:

Role names should only contain alphanumeric characters, spaces and ending with an optional pair of round brackets to specify the role type. It should not be blanked, and have a character limit of at most 30

And because this is not documented in the UG+application and that the example above shows that you can encounter this by just searching 3 common company names: shows that it can be encountered commonly. And since find command states that it supports multiple keywords, it will not be rare that a user will encounter this