support delete via click, multiple entries, sort for single + bit of cleanup

onefinestay / react-choice

Other

26 stars 8 forks source link

support delete via click, multiple entries, sort for single + bit of cleanup #10

Closed Pita closed 9 years ago

Pita commented 9 years ago

New Features:

remove elements via click on the x #5
add multiple values of the same type #6

Technical changes:

removed options from the state. You can now get the availalbe options via _getAvailableOptions. This should also fix #9
selectedValue was removed and replaced with selectedIndex. This is necassary cause a value can now be in values multiple times. Also makes the code much cleaner
_sort was moved to the mixin to allow it to be used by the single and the multiple choise

Pita commented 9 years ago

Have a look at it now, please

jkimbo commented 9 years ago

:+1:

Pita commented 9 years ago

yeah!

On 6 November 2014 15:41, Jonathan Kim notifications@github.com wrote:

Merged #10 https://github.com/onefinestay/react-choice/pull/10.

— Reply to this email directly or view it on GitHub https://github.com/onefinestay/react-choice/pull/10#event-189373614.

Peter Martischka Javascript Developer onefinestay

peter.martischka@onefinestay.com skype:pitapoison

Unit 3, 40 Bowling Green Lane London EC1R 0NE

http://onefinestay.com