search

onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

Remove dependency in tests on Component.prototype.__reactAutoBindMap #115

Open nicolassenechal opened 8 years ago

nicolassenechal commented 8 years ago

As mentioned in #72 , the dependency on _Component.prototype.__reactAutoBindMap.cx is dangerous and unnecessary. It should be replaced by testing directly the classs names.

Similarly, the DateRangePicker has a number of spies relying on __reactAutoBindMap and removing those should also be investigated.

AlanFoster commented 8 years ago

:+1: This sounds like a good thing to fix to me