search

onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

Test autobind cleanup #117

Closed nicolassenechal closed 8 years ago

nicolassenechal commented 8 years ago

What does this pull request do?

It removes the dependency on React __reactAutoBindMap in tests, testing instead the output of the functions. It also incidentally makes the tests easier to read.

AlanFoster commented 8 years ago

Awesome PR @nicolassenechal, I only have some minor questions - thanks for the hard work!

nicolassenechal commented 8 years ago

Sorry for the delay coming back, busy holidaying and relocating :)

Changed the test per the comment (and also fixed a failing test) For the white space, did you mean the carriage return? I removed it but as for setting a linting rule, I am not sure what it would be and how many extra changes would be required. It feels like it is out the scope of this PR to be fair.

AlanFoster commented 8 years ago

thanks for the great work @nicolassenechal !