search

onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

setting date value should navigate calendar to correct month if not current #125

Open jonniedarko opened 8 years ago

jonniedarko commented 8 years ago

I created a "today" button which sets the value to today. This works perfectly if it is the same month as displayed (it moves the highlighted date to the correct date) but if it's another month I feel it should update the calendar to move to the correct month.

RusAlex commented 8 years ago

Also met this bug.

AlanFoster commented 8 years ago

Sounds like a good thing to add; Happy to accept a PR

jonniedarko commented 8 years ago

@AlanFoster Any Feedback on PR welcomed

jonniedarko commented 8 years ago

@AlanFoster What is the likely hood of this being merged or getting feedback?

arvindkumarc commented 8 years ago

Im seeing this PR not being merged for a long time. This is something obvious required :)

jonniedarko commented 8 years ago

Would love to see it merged too. I already put lot of time into it but I can't justify anymore time, I feel I more then met the requirements and any new bugs that had been introduced were fixed but it is obviously the repo owners call.

On Mon, Jun 27, 2016, 3:37 AM Arvind notifications@github.com wrote:

Im seeing this PR not being merged for a long time. This is something obvious required :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/onefinestay/react-daterange-picker/issues/125#issuecomment-228673870, or mute the thread https://github.com/notifications/unsubscribe/ADgPVxH5OLILSRJAwzC-YUOGYJrLHramks5qP32sgaJpZM4HYcY4 .