Update dependencies and fix tests for React 15

onefinestay / react-daterange-picker

Other

563 stars 208 forks source link

Update dependencies and fix tests for React 15 #135

Closed thathenderson closed 8 years ago

thathenderson commented 8 years ago

This updates peerDependencies after the changes in a50d53c55d7b39e2add269aff7f36a591b51fa73, fixes a few nits in the example code, fixes a reference to renderToString() in the gulpfile, and updates the following things in a handful of tests:

fixes references to unmountComponentAtNode()
replaced all usage of getDOMNode() with ReactDOM.findDOMNode()
fixes a DOM render warning about rendering td inside tbody

After these updates, there were no console warnings in develop mode, and all tests pass: screen shot 2016-04-21 at 12 03 05 pm

Let me know if the peerDependency semver range needs to change: I did 15.x.x because that seemed to emulate the expected range. Previously, since we were using ^0.14.0, and (I think) React was pushing minor and patches on the last digit, we would have gotten both. However, I'm up for whatever you guys think is best!

thathenderson commented 8 years ago

Any chance we could get this merged soon, @AlanFoster?

thathenderson commented 8 years ago

Bumping. Do you have a few minutes to take a peek @AlanFoster?

ratson commented 8 years ago

@AlanFoster React v15 has been released about a month and 2 patch releases were out, it should be stable enough to add support for it.

thathenderson commented 8 years ago

One more bump. Any project owners that could get this merged? I think React 15 support is something we would all like.

@jkimbo @AndrewIngram

fluse commented 8 years ago

@AlanFoster please merge branches!!!!!!!

wmertens commented 8 years ago

@AlanFoster I verified this PR and it works great. The only change is that npm doesn't complain any more in projects using react-daterange-picker. It is safe to merge 👍.

AlanFoster commented 8 years ago

@thathenderson @wmertens Thanks guys; Will try to get this in ASAP! :+1:

AlanFoster commented 8 years ago

@thathenderson Thanks for the great work :+1:

ovidiuch commented 8 years ago

@AlanFoster any plans to bump the pkg version and publish updates to npm? Looking forward to using it with React 15. Thanks.

AlanFoster commented 7 years ago

Thanks for the great work @thathenderson

This should now be available on npm as version v1.1.0 - let me know if there are any issues :+1:

thathenderson commented 7 years ago

Will do, thanks for the merge @AlanFoster 👍