search

onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

Add react & react-dom to devDependencies #146

Closed andywer closed 7 years ago

andywer commented 7 years ago

Just a minor package.json fix. react and react-dom had not been installed before when cloning the repo and running npm install, so gulp build-dist failed at the end of npm install.

AlanFoster commented 7 years ago

Thanks for the PR; Small issue with Jenkins though -

npm ERR! Linux 3.13.0-63-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.15/bin/node" "/home/travis/.nvm/versions/node/v0.12.15/bin/npm" "install"
npm ERR! node v0.12.15
npm ERR! npm  v2.15.1
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package react@15.2.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer react-addons-pure-render-mixin@0.14.8 wants react@^0.14.8
npm ERR! peerinvalid Peer react-addons-test-utils@0.14.8 wants react@^0.14.8
npm ERR! peerinvalid Peer react-dom@15.2.1 wants react@^15.2.1
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/onefinestay/react-daterange-picker/npm-debug.log

Mind checking that out? :+1:

andywer commented 7 years ago

Drats! Will have a deeper look at it tomorrow morning...

andywer commented 7 years ago

Build is green again 🎉 👍

AlanFoster commented 7 years ago

Great, thanks for the PR :+1: