search

onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

Do we need Immutable.js? #149

Open eliseumds opened 7 years ago

eliseumds commented 7 years ago

I know Immutable.js can bring some performance benefits, but is it worth it in a widget that does not update that often? Projects that do not rely on it will see a big chunk of JS (55kb minifed on version 3.8.1) being included because of react-daterange-picker.

maullerz commented 7 years ago

Its really weird package with size 54kb uses and include lib with 139kb

Stats from my webpack build: i dont use immutable anywhere in project

immutable: 139.14 KB (4.50%)
react-daterange-picker: 54.17 KB (1.75%)
wmertens commented 7 years ago

It's definitely not needed, and even weird considering the other big dependency, moment, loves mutating when you least expect it. However, it is deeply entrenched and taking it out will be some work, to find all the places where the Immutable API is used on objects that are passed in.