onefinestay / react-daterange-picker

Other
563 stars 209 forks source link

incompatible with moment-range v3 #175

Closed wmertens closed 6 years ago

wmertens commented 7 years ago

I think this project should make moment and moment-range peer dependencies, and put strict ranges on them.

moment-range v3 stopped augmenting moment in-place, and instead returns a new moment object. It also has some breaking API changes.

I updated it in my project and never noticed that R-D-P has a direct dependency on moment-range. NPM dutifully provides R-D-P with its own version, and so my moment gets changed with the v2 moment-range :(

I'll see about reverting my range changes so I can go back to 2, but by making them peerDependencies, that won't happen to others.