search

onefinestay / react-daterange-picker

Other
563 stars 209 forks source link

Updated to React 16 #189

Closed james-ff closed 6 years ago

james-ff commented 6 years ago

In this pull request I have done the following:

I have run all tests / lints, which all pass, and visually tested the results in the browser and seem to exactly match the online demo for the current build.

Please check over my PR and let me know if anything is incorrect / needs adjusting!

I have made this PR so that if it is accepted I can use this component in my React 16 project, it would be a perfect fit and I would love to use it! (and can't currently if it doesn't support React 16: it seems the peerDependencies version restriction is preventing this)

Many Thanks!

AlanFoster commented 6 years ago

@james-ff Thanks for the PR! Just a quick question about backwards compatibility for earlier versions of React.

lukyth commented 6 years ago

Hi, any chance we can get this merged? Or is there anything I can help?

AlanFoster commented 6 years ago

Thanks for the PR!

sub commented 6 years ago

maybe we should update the React Version section in README?

AlanFoster commented 6 years ago

@sub Good spot; Hoping to get this out today.

AlanFoster commented 6 years ago

This is now released as v1.2.1 - Thanks again for the pull request @james-ff :+1:

Let me know if you run into any issues when installing the new release