search

onefinestay / react-daterange-picker

Other
563 stars 209 forks source link

Update moment dependency to match actual project dependencies #210

Closed jsmrcaga closed 5 years ago

jsmrcaga commented 5 years ago

Automatic installation of peer dependencies is unsupported from npm@3 onward, moving moment and moment range to dependencies avoids user confusion when using the package.

React and react-dom are still listed in peer-dependencies but a real-world usage means that the project lives with these dependencies by default, which may not be the case for moment and specially moment-range. They are production dependencies as well (the package cannot run without them or we have an unmet dependency error), which is why they were removed from devDependencies.

Feel free to discuss below!

jsmrcaga commented 5 years ago

I'm closing this PR since it has received no input in the last 20 days