onefinestay / react-daterange-picker

Other
563 stars 208 forks source link

Date highlighted ranges display breaks if earlier date inserted in array after later date. #60

Closed iiezhachenko closed 9 years ago

iiezhachenko commented 9 years ago

Initial data and result

screen shot 2015-08-09 at 6 28 41 pm

dateRanges: [{
        state: "enquire",
        range: moment.range(
            moment().add(2, "weeks").subtract(5, "days"),
            moment().add(2, "weeks").add(6, "days")
        )
    },
    {
        state: "unavailable",
        range: moment.range(
            moment().add(3, "weeks"),
            moment().add(3, "weeks").add(5, "days")
        )
    }
  ]

Data and result after modification

screen shot 2015-08-09 at 6 30 06 pm

dateRanges: [{
        state: "enquire",
        range: moment.range(
            moment().add(2, "weeks").subtract(5, "days"),
            moment().add(2, "weeks").add(6, "days")
        )
    },
    {
        state: "unavailable",
        range: moment.range(
            moment().add(3, "weeks"),
            moment().add(3, "weeks").add(5, "days")
        )
    },
    {
        state: "unavailable",
        range: moment.range(
            moment().add(3, "days"),
            moment().add(5, "days")
        )
    }
  ]
miracle2k commented 9 years ago

See my comment in https://github.com/onefinestay/react-daterange-picker/pull/57 for why this is.

iiezhachenko commented 9 years ago

Thank you.

TimBeyer commented 8 years ago

It doesn't seem like this has ever been fixed. I think it should be reopened @iiezhachenko. In my opinion, the calendar should sort those ranges.