Test setup - Githubissues

onefinestay / react-daterange-picker

Other

563 stars 208 forks source link

Test setup #72

Closed nicolassenechal closed 8 years ago

nicolassenechal commented 9 years ago

This pull request adds unit tests to the project. It fixes #9 . A minor bug was also discovered in shallowEqual.js and fixed.

To test, please follow these steps: npm install gulp test-unit (for running karma as a permanent task in phantomjs) gult test-coverage (for running karma only once and generating a coverage report)

Current line coverage currently sits at around 95%. Improvements would include the following:

Dropping the shallow renderer and only using the document renderer. This would simplify the overall testing logic.
Refactoring and splitting DateRangePicker.jsx as the logic in this file is very complex and testing was a bit convoluted and difficult. Both changes would be pretty big, so I prefer to leave them out of this task.

jkimbo commented 9 years ago

This is fantastic, thanks so much! I'm going to a quick review but I would love to get this out as soon as possible!

jkimbo commented 9 years ago

All looks great! If you could address the small comments above and I'll get this released as soon as possible!

AlanFoster commented 9 years ago

Awesome to see tests! :)

nicolassenechal commented 9 years ago

Should be ready to be merged in!

nicolassenechal commented 8 years ago

Really good pick. Moved the helper functions inside the top level beforeEach and remove the arrow notations on beforeEach, it and describe

AlanFoster commented 8 years ago

Thanks for the great work on this @nicolassenechal

AlanFoster commented 8 years ago

@nicolassenechal Looks good to me - Would you be able to rebase this and squash some commits to make the commit history slightly nicer, then we can go ahead and merge this. Thanks again for the work!

nicolassenechal commented 8 years ago

Done.

I will create separate MRs for:

memory leaks linked with useDocumentRenderer (I now believe it is an issue based on another of my projects, killing karma if cleanup is not done )
webpack/karma file cleanup
testing around the bem class names

AlanFoster commented 8 years ago

@nicolassenechal Brilliant; Thanks!