search

onehilltech / ember-cli-mdc

ember-cli addon for material-components-web
Apache License 2.0
44 stars 15 forks source link

remove class on row header #26

Closed reiallenramos closed 4 years ago

reiallenramos commented 4 years ago

The official docs doesn't have a class in the thead element: https://material.io/develop/web/components/data-tables/

<thead>
      <tr class="mdc-data-table__header-row">
         ...
      </tr>
    </thead>
hilljh82 commented 4 years ago

@reiallenramos Thank you for the PR, but this is actually correct. This package is a wrapper for Material Components Web. Please see the current implementation of the data tables package.

hilljh82 commented 4 years ago

@reiallenramos Actually, I see where you update is and you are correct! Thank you for the PR.

hilljh82 commented 4 years ago

@reiallenramos Thank you!

reiallenramos commented 4 years ago

@hilljh82 you're welcome! Not sure how npm packages work, but I dont see the changes when I delete node_modules/ember-cli-mdc then npm install. Are you familiar?

hilljh82 commented 4 years ago

@reiallenramos I have to publish a new prerelease. I just did so. You should be able to do 

ember install ember-cli-mdc-data-table

to get the latest prerelease with your change.