search

onehilltech / ember-cli-mdc

ember-cli addon for material-components-web
Apache License 2.0
44 stars 15 forks source link

add 'disabled' classNameBinding and attributeBinding to list item #5

Closed jamesstaub closed 5 years ago

jamesstaub commented 5 years ago

Allows usage of MDC disabled list item style

hilljh82 commented 5 years ago

@jamesstaub Thank you for the full request. I am curious why you are adding disabled to attributeBindings, and not just to classNameBindings? It seems the correct solution is to update the classNameBindings with support for disabled list items? attributeBindings are for adding HTML attributes to the component tag. Let me know if I am missing something.

jamesstaub commented 5 years ago

You're correct, I was misunderstanding how the bindings worked. Please see latest commit.

hilljh82 commented 5 years ago

@jamesstaub Thanks for making the corrections. I will go ahead and merge the pull-request. I am going to assume this is a feature you need right now. If so, I can go ahead and make a quick release.

jamesstaub commented 5 years ago

it is indeed, thank you!

hilljh82 commented 5 years ago

Done!