search

onehouseinc / LakeView

Monitoring and insights on your data lakehouse tables
Apache License 2.0
22 stars 7 forks source link

[110] Update the README.md file #113

Closed rangareddy closed 1 month ago

rangareddy commented 1 month ago

Important Read

This pull request aims to address issues #110

What is the purpose of the pull request

Updated the README.md file by adding sections and update the steps to run.

Verify this pull request

Checked README.md file and contents looks good.

alberttwong commented 1 month ago

I like it, but there are a lot of changes. I think that we need to have multiple reviewers. I'd like to @andywalner to review.

alberttwong commented 1 month ago

@rangareddy can you check the README again? There is conflicts.

rangareddy commented 1 month ago

@rangareddy can you check the README again? There is conflicts.

Fixed the Merging conflicts. Please review the latest README.md file contnet.

alberttwong commented 1 month ago

ci failed

rangareddy commented 1 month ago

ci failed

This could be happen due to SONAR token was expired or became invalid or sonar class issues.

CC: @pkgajulapalli

pkgajulapalli commented 1 month ago

ci failed

This could be happen due to SONAR token was expired or became invalid or sonar class issues.

CC: @pkgajulapalli

@rangareddy I see the sonar step is working fine in https://github.com/onehouseinc/LakeView/pull/115. Can you please try raising a PR from a different branch in this repo itself?

I see sonar_token secret is not picked up in this PR, but it is getting picked up in the other pr.

rangareddy commented 1 month ago

Hi @alberttwong

Raised a new PR by changing the git default origin to onehouse origin.

https://github.com/onehouseinc/LakeView/pull/117

rangareddy commented 1 month ago

Raised a new PR to fix the Sonar build failed Issue i.e 117. So closing this PR.