search

onejar99 / gitbook-build-publish-action

A GitHub Action to build and publish GitBook.
19 stars 8 forks source link

$MY_SECRET will be printed #1

Closed yzgyyang closed 3 years ago

yzgyyang commented 3 years ago

I am just wondering if this is a security hazard to print $MY_SECRET - which could be a user's access GH token.

https://github.com/onejar99/gitbook-build-publish-action/blob/master/entrypoint.sh#L20

onejar99 commented 3 years ago

$MY_SECRET will be masked by GitHub Action when printing, so the access token won't be disclosed. But it's unnecessary to print it. I have removed it. Thank you for reminding!