onekey-sec / unblob

Extract files from any kind of container formats
https://unblob.org
Other
2.16k stars 80 forks source link

Package for nixpkgs? #424

Open dit7ya opened 2 years ago

dit7ya commented 2 years ago

I was about to try packaging this for nixpkgs but then noticed the flake.nix in this repo. Thought it would be better to ask you first.

vlaci commented 2 years ago

I've been wanting to do the same, however the current packaging relies on poetry2nix which afaik shouldn't be used in nixpkgs packages if at all possible. I have a draft branch somewhere which tries to get rid of poetry2nix and packages all dependencies 1 by one natively, however I got stuck with python-hyperscan, as it is a huge pain in the butt to build. If you are interested in working on it, I can clean-up my existing branch and push it up.

The roadmap upstream for me woud be something along the lines of:

qkaiser commented 1 year ago

@vlaci what's the status on this now that we have merged https://github.com/onekey-sec/unblob/pull/516 ? Are we ready to open a PR for an unblob Nix package ?

vlaci commented 1 year ago

@vlaci what's the status on this now that we have merged #516 ? Are we ready to open a PR for an unblob Nix package ?

Updated the above todo list. Next step I see is resolving sasquatch.

vlaci commented 1 year ago

Opened a meta-issue in nixpkgs: https://github.com/NixOS/nixpkgs/issues/217836

qkaiser commented 11 months ago

I think there was some movement on the meta-issue and linked MRs. What's the current status ?

AkechiShiro commented 6 days ago

Just to update here : sasquatch was merged recently

vlaci commented 6 days ago

Just to update here : sasquatch was merged recently

I know :relaxed: https://github.com/NixOS/nixpkgs/pull/345554

AkechiShiro commented 6 days ago

Thanks a lot ! I'll review soon