onekey-sec / unblob

Extract files from any kind of container formats
https://unblob.org
Other
2.15k stars 80 forks source link

Extend default skip magic rather than overwrite it. #693

Closed qkaiser closed 8 months ago

qkaiser commented 8 months ago

unblob has a decent default skip magic list that gets overwritten if a user provides its own, which means unblob users need to redefine all of unblob's default skip magic through the CLI whenever they provide their own.

Changed the logic so that user provided skip magic values are simply appended to unblob's default list.

This is an opinonated change, but we think unblob default skip magic is well thought out and the inability to fully overwrite it should not be a problem for the vast majority of our user base.

Related to #647