onekey-sec / unblob

Extract files from any kind of container formats

https://unblob.org

Other

2.14k stars 81 forks source link

Support aarch64-darwin "Apple Silicon" devices #724

Closed ljrk0 closed 7 months ago

ljrk0 commented 7 months ago

Is your feature request related to a problem? Please describe.

516 added macOS x86 and Linux ARM support but macOS ARM isn't supported:

error: flake 'github:onekey-sec/unblob' does not provide attribute 'packages.aarch64-darwin.default' or 'defaultPackage.aarch64-darwin'

Describe the solution you'd like Support for the aarch64-darwin target in the build pipeline.

Describe alternatives you've considered N/A

Additional context N/A

qkaiser commented 7 months ago

Hi @ljrk0 ! I'm only seeing your issue now, the darwin-aarch64 package should be available now. We're building it using Github Apple M1 runner since https://github.com/onekey-sec/unblob/pull/741

Can you confirm it works ?

ljrk0 commented 7 months ago

Thank you for coming back to me! I missed though that the core issue is not the CI but the build flake for Nix not claiming macOS on ARM support. Had some time to investigate and add the small fix :)