search

onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.
http://www.onekiloparsec.dev/
MIT License
171 stars 31 forks source link

Remove bogus Foundation.framework embedding #106

Closed alex-vasenin closed 3 years ago

alex-vasenin commented 3 years ago

Embedding Foundation.framework into ObjCAA target doesn't make any sense, because this framework is part of iOS.

I've got following error while uploading my app to App Store Connect with embedded Foundation: ERROR ITMS-90206: "Invalid Bundle. The bundle at 'MeteorActive.app/Frameworks/ObjCAA.framework' contains disallowed file 'Frameworks'."

onekiloparsec commented 3 years ago

I fail to make a CocoaPod release. Running pod lib lint allow-warnings SwiftAA I get 

    - ERROR | xcodebuild:  /Users/onekiloparsec/code/SwiftAA/Sources/SwiftAA/Earth.swift:55:117: error: extra argument in call
    - ERROR | xcodebuild:  /Users/onekiloparsec/code/SwiftAA/Sources/SwiftAA/Earth.swift:55:98: error: cannot convert value of type 'KPCAAPlanetStrict' to expected argument type 'Bool'

WTF

onekiloparsec commented 3 years ago

@alex-vasenin any idea ?

alex-vasenin commented 3 years ago

@alex-vasenin any idea ?

Hi Cédric! Have no idea, but I can check once I’ll back from vacation on 20th.

alex-vasenin commented 3 years ago

@onekiloparsec It seems like SwiftAA.podspec for 2.3.1 still has ObjCAA v.2.3.0 dependency, so pod lib lint builds ObjCAA 2.3.0 and tries to feed it to newer SwiftAA 2.3.1 which fails due to mismatched method signatures. Don't forget to to add 2.3.1 tag!

onekiloparsec commented 2 years ago

Thanks. ObjCAA and SwiftAA 2.3.1 released.