search

onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.
http://www.onekiloparsec.dev/
MIT License
172 stars 31 forks source link

fixed bug: calls to ecliptic/equatorial transform should use obliquity #11

Closed alex-vasenin closed 7 years ago

alex-vasenin commented 7 years ago

fixes issue #5

notes:

  1. not sure which obliquity to use: mean or true
  2. the might be similar bugs in other places
onekiloparsec commented 7 years ago

That's great, thanks again. About mean or true for the obliquity, I am undecided. What about a method parameter with a sensible default? I must check the book itself about the exact difference first.

Could you add a unit test to avoid regression on that point?